[5.1] Update deleted files list in script.php for 5.1.3 #43944
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
|
Thx |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request for Issue # .
Summary of Changes
This pull request (PR) updates the list of files to be deleted on update in file
administrator/components/com_admin/script.phpin the 5.1-dev branch in preparation for the next 5.1.3 release.All files added by this PR are deleted due to the update the joomla framework composer dependencies, where developer-only files are not shipped anymore.
Code review, or if you want to do a real test:
Update a 5.1.2 to a current 5.1-dev build which contains the changes from the merged PR #43943 to get the actual result, and update a 5.1.2 to the patched package created by Drone for this PR to get the expected result.
To create a current 5.1-dev build, open a Linux or WSL shell, change to the base folder of your git clone, checkout the 5.1-dev branch of the CMS repo or update your 5.1-dev branch to that (upstream) and then run:
And here you can find the patched update package or custom update URL created by Drone for this PR: https://artifacts.joomla.org/drone/joomla/joomla-cms/5.1-dev/43944/downloads/78199/Joomla_5.1.3-rc2-dev+pr.43944-Development-Update_Package.zip
Actual result BEFORE applying this Pull Request
The files added by this PR to file
administrator/components/com_admin/script.phpare still present after the update.Expected result AFTER applying this Pull Request
The files added by this PR to file
administrator/components/com_admin/script.phphave been removed with the update.Link to documentations
Please select:
No documentation changes for docs.joomla.org needed
No documentation changes for manual.joomla.org needed